Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test: browser default underline styles #1541

Closed
wants to merge 1 commit into from
Closed

Test: browser default underline styles #1541

wants to merge 1 commit into from
+0 −7

Conversation

jamesmockett
Copy link
Contributor

@jamesmockett jamesmockett commented Jun 13, 2024 •
edited
Loading

What are you changing?

  • Removes custom link underline styles

Why?

  • The Design System team are considering removing these in favour of default styles, so this is so they can see how it looks in the browser

Screenshots

Note

All screenshots are from macOS

Basic link

Chrome Safari Firefox
Screenshot 2024-06-13 at 16 45 39 Screenshot 2024-06-13 at 16 45 48 Screenshot 2024-06-13 at 16 47 17

Additional examples

Chrome

Screenshot 2024-06-13 at 16 44 42 Screenshot 2024-06-13 at 16 44 49

Safari

Screenshot 2024-06-13 at 16 45 07 Screenshot 2024-06-13 at 16 45 17

Firefox

Screenshot 2024-06-13 at 16 46 56 Screenshot 2024-06-13 at 16 47 05

@jamesmockett jamesmockett self-assigned this Jun 13, 2024
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jun 13, 2024

⚠️ No Changeset found

Latest commit: bcd9624

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jamesmockett jamesmockett added 🙅 Do not merge run_chromatic Runs chromatic when label is applied labels Jun 13, 2024
@github-actions github-actions bot added the 📦 npm Affects a @guardian package on NPM label Jun 13, 2024
@github-actions GitHub Actions
Copy link
Contributor

Tip

Once this PR is ready to go, add the run_chromatic label to run the Chromatic tests.

This saves us a lot of money by not running the tests before we need them.

@jamesmockett jamesmockett linked an issue Jun 13, 2024 that may be closed by this pull request
Create prototype showing default link styles for Design System team to review #1540
Open
@github-actions GitHub Actions
Copy link
Contributor

"This PR was marked stale because it has been open for 30 days without activity. If nothing happens, it will be closed 3 days from now."

@github-actions github-actions bot added the Stale label Jul 14, 2024
@github-actions GitHub Actions
Copy link
Contributor

This PR was closed because nothing happened for 3 days after becoming stale.

@github-actions github-actions bot closed this Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jamesmockett jamesmockett

Labels
🙅 Do not merge 📦 npm Affects a @guardian package on NPM run_chromatic Runs chromatic when label is applied Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create prototype showing default link styles for Design System team to review
1 participant
@jamesmockett